abhagwat

Results 6 comments of abhagwat

Another sign that some internal invariant in gVisor might have been violated: the `pkt` from the serialized PacketBufferList has refcount 0 (when it's loaded from the checkpoint). This is in...

My current tenuous working theory is this -- most stateify-savable objects in gVisor implement a `beforeSave` hook that performs synchronization: this hook generally drains pending work, stops background goroutines, etc...

Here's an [example](https://github.com/google/gvisor/blob/b60a9bdc45fe99ab707746543fc7f5e9bab34e34/pkg/sentry/kernel/timekeeper.go#L191) of the "stop goroutine before serializing the data structure it manages" pattern.

I've been working on reproducing this problem in a gvisor unit test -- it certainly looks like `state.Save(..., mgr)` (where `mgr` is a `processorManager`) crashes very easily when `mgr` has...