Ali Beyad

Results 102 comments of Ali Beyad

> Thanks! One high-level comment, instead of adding the extension under the "xds" directory, it should probably be under the path name "config". Done, thanks for the review! Addressed the...

> still letting Adi drive here but you'll want to sync past the merge conflicts when you have a few :-) PR has been updated with the latest from upstream/main

The proto format failures have disappeared, with adding the allow-fully-qualified-name annotation introduced in https://github.com/envoyproxy/envoy/pull/23163

@adisuissa friendly ping; I pushed up a commit containing an integration test that shows we handle invalid proto enums properly.