Abdullah Sahin comments

Results 7 comments of


                                            Abdullah Sahin

fix(release): allow multiple tags on the same commit for separate branches

Following is from the content of the .projenrc.ts ```typescript defaultReleaseBranch: "main", prerelease: "pre", //main branch is designed to be a pre-release of the major release releaseBranches: { "release/0.x": { majorVersion:...

fix(release): allow multiple tags on the same commit for separate branches

For the above configuration I mentioned, if there is a **v1.0.0-pre.0** release on main branch and if you apply the same commit on **release/0.x** branch, you try to release **v1.0.0-pre.0**...

fix(release): allow multiple tags on the same commit for separate branches

@mrgrain , how about adding a new property named **branchIdenpotentRelease**( I am open to suggestions for the name), set it as **false** by default and if true then we can...

fix(release): allow multiple tags on the same commit for separate branches

> Yeah I think a property would definitely be the safest option. But tbh I'm still trying to understand how this change is working. It might be okay to be...

fix(release): allow multiple tags on the same commit for separate branches

> Alternatively taking a step back @abdsahin - Maybe what we actually want here is a `--force` option on the command that users can use to always force a new...

fix(release): allow multiple tags on the same commit for separate branches

@mrgrain , I've updated the branch, let me know if it looks better, we merge or close it accordingly.

jf poetry install runs poetry update

Any feedback here? To be honest, I wonder the reason why ```poetry update``` is run here. When I run ```jf poetry update```, poetry update is run twice and no build...