Boyang Chen
Boyang Chen
Thanks for the comments. For integration test I was planning to address it after you took an initial look at current logic. For #5 my question was if we don't...
Oh I think I got it for now, as we have already defined readIndex timeout, so as long as it's not timing out, we should be assuming it's successful. As...
That also sounds like a valid solution. We could discuss further on Wechat to see whether that's necessary.
Thanks! Will rebase the change. However, I'm not sure we still need it.
In https://github.com/etcd-io/etcd/blob/9f81002a11b55c5f53b76b3c00b1e83529d0eaab/etcdserver/api/membership/cluster.go#L286, there is a flag in config change to indicate the request is for promotion. Do we also want to add such a safety check?
retest this please
@sazzad16 is this documented somewhere? Could you add a meta comment to draw user's attention?
Hey there, I'm the original author of static membership. Really appreciate all the efforts here, and I hope @sandeepkumarcel could work with me together to get this landed soon.
@Fullstop000 Thanks for the reply. It would be good to add such details to RFC for sure :)
Same here, this is really useful.