Aashan Ghimire comments

Results 13 comments of


                                            Aashan Ghimire

Improvement: site event handling

@TobiSW the changes seem fine .. however phpstan is giving some errors, could you update your pr with thr latest changes from 11.x branch?

Improvement: site event handling

@dvesh3 could you please approve the workflow run?

[EcommerceFrameworkBundle] Refactored as per modern bundle structure

@dvesh3 please fix the conflicts :)

Notes: Missing delete option

@blankse any updates on this one?

Notes: Missing delete option

@blankse The changes in this pr work fine, however I have a question. If a note is locked by default, shouldn't there be some option to "unlock" a note? Or...

Notes: Missing delete option

In that case, everything else looks good to me! Thanks @blankse

Replaced return type in `InstallerInterface::getOutput` method to be `BufferedOutput`

@jdreesen changed it according to the discussion.

Refactored getMetadata method of Asset to include unused parameters

@kingjia90 I have brought back the two loops and added filters for `$language` and `$strictMatch` on the case with no `$name`. Please have a look now!

Refactored getMetadata method of Asset to include unused parameters

@kingjia90 I have made changes accordingly!

Refactored getMetadata method of Asset to include unused parameters

@kingjia90 I have added the tests. Please have a look