Aaron Davidson
Aaron Davidson
Sorry for the delayed review! Looks pretty good, left a few comments. It seems there may be some test issues as well: https://travis-ci.org/github/mlflow/mlflow/jobs/690565858
Any progress on this issue? Would love CSI support for hypervisor runtimes like kata.
LGTM - thanks! Retriggering tests.
Not certain, but if at the time I cared enough to file this issue, we probably weren't even nearly saturating any of our disk/memory/CPU, so I would expect at least...
I consider the first slightly preferable for the same reason why we prefer braces around defs which are not one-liners.
(btw - turns out only `handprint` depends on guava, so if you want to just use the standard fingerprint stuff, you can just remove the main and test files for...
Writing to Tachyon with a WriteType without "THROUGH" could be very unstable. In Shark, for instance, cached tables are persisted in Spark with MEMORY_AND_DISK, so that when the data is...
Alright, sounds fine to me, as long as the use case you had in mind can tolerate data randomly falling out of Tachyon. This change looks good to me, though...
Uh, looks good to me but I'm not a committer on this project :) @rxin, care to merge this?