Aaron Pittenger
Aaron Pittenger
Any questions or feedback on this PR that I can help to answer?
This PR has been sitting for quite a while. Any chance this is even on the radar to get merged in? @hassankhokhar @boardthatpowder @rrangnekar
I see there's some movement on this repo again! Is there an appetite to merge in this Pull request (or any other community pull requests)? @ts-amz @canavandl @BenjiTheC
One last effort here to get any kind of feedback from anyone on the team, otherwise we will just fork this and manage it on our own. Is this even...
Yes - I do plan on working this. I just don't have the time to do it right now. It will probably be in a month or so
@ts-amz - rebased on main
@ts-amz @canavandl - FYI, just made a couple more updates to this. Unit tests are included with #193. We've pushed this out to our system to ensure it's working. I...
After running for a few days in our production environment, this asset library history batching has reduced our total lambda duration by about 60% and reduced invocations by 99%.
Actually - after thinking about this a little bit more, the assetlibrary-history lambda might be a better one to tackle batching for. The device monitoring lambda tends to do well...
If I had to guess, it would be [here](https://github.com/aws/aws-connected-device-framework/blob/b3f58fc9cd4de2b6f9ce91dcd829d77aa3399efd/source/packages/services/device-monitoring/src/assetlib_update.ts#L39). Looks like we just catch any errors, print a log message and move on. We should probably just `throw` there