Ameen Sayegh

Results 5 issues of Ameen Sayegh

I just spotted something that might overflow the `Partitioner->Items` buffer by one item: https://github.com/cmuratori/refterm/blob/91e932f011e12c02a6c609ac59570f5c19fe4727/refterm_example_terminal.c#L394-L397 The [`ScriptItemize` function](https://docs.microsoft.com/en-us/windows/win32/api/usp10/nf-usp10-scriptitemize) wants you to pass `ArrayCount(Partitioner->Items)-1` as `cMaxItems` parameter to be able to put...

Sorry for not submitting a pull request, I'm working on a bignum library and I saw your implementation of multiplication so I just want to point out that you can...

help wanted
good first issue

I found something that will cause a problem in the future when adding new key bindings: https://github.com/serge-rgb/milton/blob/c2a9dc3d9e6c045d1d71cbcdb08b0e56cb2b9ee7/src/bindings.h#L50-L57 Adding new bindings must be before `Action_COUNT`. However, this reordering will cause a...

bug

The byte 0x80 is no a valid utf-8 but the function doen't return GB_RUNE_INVALID

Hi, This is not a really an issue, feel free to close this. I was looking into the [JSF RNG](https://burtleburtle.net/bob/rand/smallprng.html) and I thought it is worth mentioning that the implementation...