Aleksandr Alekseev
Aleksandr Alekseev
#29 seems relevant
Maybe we can revert this [revert](https://github.com/pion/webrtc/commit/1d12dc8f765b19407fb1965240874e00d5a4f8cb) as networkType is not "tcp4"/"tcp6"/etc according to the webrtc-stats?
Also, I find very confusing that we have `func (pc *PeerConnection) OnICEGatheringStateChange(f func(ICEGathererState))` not `func (pc *PeerConnection) OnICEGatheringStateChange(f func(ICEGatheringState))` even though getter is more accurate: `func (pc *PeerConnection) ICEGatheringState() ICEGatheringState`...
@at-wat, no, I think this change would be too radical :) I'm just suggesting changing the return type of `OnICEGatheringStateChange` from `ICEGathererState` to `ICEGatheringState` (both types already present in implementation)....
@grahamking, Hi! Thanks for the review, are there any blockers for merging?
Unfortunately, it's a known issue with the current implementation – I will make a reproduction in bwe-test repo: https://github.com/pion/bwe-test/issues/54
@3DRX, do you think that it would be better to feed RTX/FEC packets to the same stream as the media packets? These streams are not separate in BindLocalStream, so it...
@3DRX, I'm concerned not only about breaking RTX implementation in users' interceptors, but also about breaking the existing interceptors' logic which expects packets of only one SSRC inside the stream....
@mengelbart, I like this idea. I think it would be convenient to keep the BWE implementation and tests in the same place. Maybe we can use the existing pion/bwe-test repository...