Bruno

Isolate dependency on scorex.crypto to a single file

1

Before this PR, many files in scorex.core depended on scorex.crypto. This PR creates a file that serves as interface to scorex.crypto. All other files now only depend on this new...

Why does Scorex use custom serialization and de-serialization?

1

While working on #221 I noticed that most of the uses of `Array` happen inside Scorex's custom (de)serializers. Moreover, most of the (de)serializers are very similar to each other. That's...

I will do this after #213 is accepted.

Right now the message `DataFromPeer` is received by two actors: `PeerSynchronizer` and `NodeViewSynchronizer`. And it is sent by `NetworkController`, which has a sophisticated and generic _message handling_ mechanism to decide...

Reorganize and document where messages come from

24

Scorex's code organization and documentation would be greatly improved if we were more systematic about where we define messages and how we import them to be used elsewhere and about...

Section 5 of this paper (https://pdfs.semanticscholar.org/deb1/c04f3584a59b489e9582b244c10c7f9b20cf.pdf) discusses some interesting ideas.

Alternative to keeping an actor's state in mutable collections

2

I noticed that `NodeViewSynchronizer` has a few global mutable collections to keep state information. An alternative to that could be to use the `become` approach and pass state information as...

Investigate whether we could/should make more use of "ask" instead of "tell"

1

See https://github.com/ScorexFoundation/Scorex/issues/162#issuecomment-361790890 .

https://github.com/ScorexFoundation/Scorex/tree/master/examples We have user demand for this information. Here is what a user asked in the gitter channel: > Hi. I'd like to know if there are instructions about how...