Zachary R. Smith

Thanks for the issue, @Nikodermus . Unfortunately, I'm not sure when I'll be able to look at it. Would you please PR a fix?

thanks for the thoroughly written issue, @shepswitcher . unfortunately i am busy and cannot look into it right now. maybe this weekend?

@shepswitcher as you may have noticed, i did not get around to it last weekend, and i doubt i will this week

react-router's history.block() is not being invoked, so fixing this would require a solution similar to what NavigationPrompt is doing with `window.addEventListener('beforeunload', this.onBeforeUnload);` I looked into using window.addEventListener('popstate'), but the event...

My bad, I had a filter that caused me to not see the logs history.block() was making. This is quite an edge case! It seems that react-router is ignoring the...

Thanks for the issue, @mcupito . When you say "Prompt closes and nothing else happens, but _the URL stays the same_", do you mean that the URL stays at `test.com/x`...

Also, it looks like you're passing NavigationPrompt's onConfirm as ConfirmModal's onActionClicked and calling ConfirmModal's this.testActionClick. Would you please share the method this.testActionClick?

@mcupito are you using react-router's HashHistory instead of BrowserHistory? unfortunately, NavigationPrompt is not compatible with HashHistory (i think...i haven't tested it). it seems someone else had this issue with HashHistory:...

Thanks, @riteshahlawat ! If anyone reading this would like to open a PR that uses history.replace() when using HashHistory, I think I'd merge. Cheers!

This is not currently supported. Please open a PR if you get it working!