Zac Hatfield-Dodds

Results 696 comments of Zac Hatfield-Dodds

This is still present in Black 19.10b0 - it's a different bug to #922/#948; Python ignores a trailing backslash but Black chokes on it.

"Ignore this until py37 reaches end of life" seems like a reasonable plan to me, and it's easy enough to adjust the tests accordingly.

Aw, *heck*. Form-feed (`\x0c`) is always tricky... see e.g. https://github.com/Instagram/LibCST/issues/446. I think we should just check `"\\" in src_contents` instead of using regex 😅

I'd caution strongly *against* adding shades: - The minimal-configuration aspect of `black` is very valuable for user experience across projects. - Semantic changes are much more contentious than formatting alone....

> In practice that sort of scenario doesn't seem terribly likely, so I'd be OK with making target_version just a minimum requirement. I was very surprised to discover it wasn't...

I'd hope the answer is "Python 2 taught us not to make breaking changes to the syntax" - and if we do, adding an optional `--maximum-version` argument will be the...

I can confirm that 0.2.5 works :smile:

@nedbat I can confirm that this is some combination of fixed, and a misunderstanding around #867. You can see in https://github.com/HypothesisWorks/hypothesis/commit/f523ae5d709fe3dea2b8c5b2f68a620608d53a15 that the surviving branch was "if-true in finally only...

You know what would be amazing? Symbolically executing tests written for [Hypothesis](https://hypothesis.readthedocs.io/en/latest/quickstart.html)! For example: ```python @given(st.integers(min_value=0)) def test(x): assert x ** 2 >= x # could be equivalent to def...