ZXShady

Results 69 comments of ZXShady

Pass `sf::Vector2<T>`s by value

still passing by reference Glsl::Vec2 in Shader.hpp at line 333 and Glsl::Vec2 is an alias to sf::Vector2f

Pass `sf::Vector2<T>`s by value

still passing by reference Glsl::IVec and BVec in Shader.hpp the number is the line number `378 void setUniform(const std::string& name, const Glsl::Ivec2& vector); // alias to sf::Vector2i` `422 void setUniform(const...

pass sf::Vector2<T> and sf::Vector3<T> by value instead of by references

@ChrisThrasher Hi, I am very sorry, for the extremely late reply 3 whole weeks. passing by reference means if the compiler cannot know the body of the function (i.e defined...

pass sf::Vector2<T> and sf::Vector3<T> by value instead of by references

It also saves keystrokes I say that is another benefit /joke sad that const references are not really `const` if you get what I mean. also this applies to most...

pass sf::Vector2<T> and sf::Vector3<T> by value instead of by references

@ChrisThrasher What more evidence do you need (asking politly)? I understand this is such a big change to the entire codebase. but it is even recommended practice by cppcoreguidlines https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-in...

pass sf::Vector2<T> and sf::Vector3<T> by value instead of by references

> https://github.com/SFML/SFML/pull/3140 > > At a minimum we can make this change for all 2D vectors. Whether we make the change for 3D vectors can be discussed further and handled...

pass sf::Vector2<T> and sf::Vector3<T> by value instead of by references

@Bambo-Borris I have no benchmark ready right now But I have posted Godbolt links that show the differences and optimizations possible by pass by value We are helping the compiler...

Consider adding rvalue overload for sf::String::operator+ to allow move semantics

Standard says: `when a temporary class object that has not been bound to a reference (12.2) would be copied/moved to a class object with the same cv-unqualified type, the copy/move...

Consider adding rvalue overload for sf::String::operator+ to allow move semantics

@eXpl0it3r I am sorry I think I am not focused this is all wrong lol. I am so wrong and the draft I linked was old there is no elisions...

Feature request: remove prefix from enum name

Hi durka, is this still needed? if so I will make a pr for it