Richard Zhuang

Results 14 comments of Richard Zhuang

@dopplershift @dcamron Hi MetPy developers -- I would really appreciate it if I could get some feedback on this PR. The math here is pretty straightforward: - We can plug...

The derivation for CCL. The `T` in the last step is the temperature profile with a constant mixing ratio. ![image](https://user-images.githubusercontent.com/38182337/190540919-02e15277-f691-46cb-a805-81eb3640aa20.png)

Thanks for the suggestion! I should have speculated that this was implemented somewhere in MetPy, but I would have never figured out what those `globals()` mean on my own. I...

And one last thing: I just realized that the unit handling in this function is terribly wrong but somehow escapes the test cases. It seems that `assert_almost_equal` in `metpy.testing` thinks...

@dopplershift Never mind the unit issue. It turns out that I should also add `assert input.units == output.units` to explicitly test for unit, and I was just implicitly thinking that...

I think it would be worth the effort to bundle `LCL`, `LFC` and `CCL` into a single example gallery as a separate PR because it makes the most sense to...

One last question: should the docstring description ``` This function is implemented directly based on the definition of the CCL, as in [USAF1990]_, and finding where the ambient temperature profile...

This should be good to go in. Could you do a final check?

I want to give this implementation a shot but I am a bit confused about what the interface should be. IMO, the interface should be a combination of several types...