Yuri Sizov
Yuri Sizov
I think, to be safe, I'd keep the `EditorNode` itself as `Node` and keep _one_ GUI root node with the theme applied to it as its child. And then I'd...
> I guess I'm okay with this, but what exactly is the risk with turning EditorNode into a Panel? EditorNode is the root of the entire editor tree, and people...
Okay, given that you've said on RC that the observed performance boost is more like a performance regression in the current master, I guess that closes that angle. But I...
Ah, I knew about setters, but didn't think about them in the context of the API generation. Makes sense. But it doesn't look like `test_class_db.h` would be enough. We also...
Well, thank god we don't have tests in 3.x then 😛
From `test_class_db.h` testing alone, there are 17 cases of unnamed parameters, mostly setters: ``` =============================================================================== [doctest] test cases: 596 | 595 passed | 1 failed | 1 skipped [doctest] assertions:...
@akien-mga Done! I hope this is to your satisfaction. I've added a second commit that adds tests to ClassDB, Variant, and GDScript, and fixes what these tests have unearthed.
The feature is approved otherwise, by the way.
Well, maybe the existing setting should be made project setting instead of an editor setting 🤔 There were some concerns that you'd have this problem with one project but not...