Dominik Baran

Results 22 comments of Dominik Baran

I was using 2.7.0 when I first encountered this issue. Then I switched to 3.0.2 but it didn't help. I just tested this on 2.9.0 and the result is the...

Few things from what I noticed: 1. We can't pick a converter just by looking at the file extension like we do it right now: https://github.com/icsharpcode/CodeConverter/blob/7a4bcd1d66841bc90b145a5b88223b507caae98e/Vsix/CodeConversion.cs#L336-L339 I'm pretty sure this...

Sadly from my observations, it doesn't work like that for aspx/ascx files. If you open a markup file and save it VS will override these changes. ![image](https://user-images.githubusercontent.com/9254709/165717391-8fd0f3b8-c315-4ae1-a245-501c0fd7bd37.png) Not sure if...

Few more observations: 1. This hidden project for aspx/ascx files is only created when you actually open the file in VS. Makes sense - if you have a few thousands...

Another problem. Probably a bit more serious. My guess is that we throw duplicated key exceptions from the dictionary that handles renaming. ```vb Private Sub TestMethod2() For i = 1...

And third issue. Still related to renaming so I will keep it under this issue. ```vbnet Public Class Data Public Property a as Integer End Class Public Class VisualBasicClass Private...

1) To fix this: where expressions should be **probably** included in https://github.com/icsharpcode/CodeConverter/blob/db94fb3d006d53bb9fb1689a58febcc19db8cadd/CodeConverter/CSharp/VbSyntaxNodeExtensions.cs#L23 2) Might be an opportunity to simplify the patterns that we have to generate to handle vb nullable...

> > I think most people don't put labels in their code > > There are a lot of them in 20 years old code ;) > > But I...

@KunzeAndreas are you sure that ```testResult``` should be true? Running the input code on my machine results in ```testResult``` being ```False```: https://ideone.com/usf5f6 [SharpLab.io](https://sharplab.io/#v2:DYLgbgRgNAJiDUAfAkgWwA4HsBOAXAzgAQDKAnvrgKaoCwAUAAoCuEwAlgMaEDCwAhviLd6hUYWatOJFoQCyACgCUIsaoAibVISoVuACz7ZCAQSEGjAXkIA5TLj1sAdgHMVq0Rq07cAJUr4mYFxCK299QxDCACIot0IAUUcYaQh6ROTeAXwgA===) shows that there is actually a call...

Thanks @KunzeAndreas, now I see what's happening and how to reproduce it. You need to set: ```vbnet Option Compare Text ``` Which then will yield: bool flag = Operators.CompareString(Conversions.ToString(c), "",...