Yossi Saadi

Results 25 comments of Yossi Saadi

> Maybe also worth adding RelatedComponents, if u can think of any - just to be consistent great suggestion, for the meantime Yael and I agreed that since we need...

@shlomitc @SergeyRoyt you had great suggestions, I'll go over the content/design-related also with Yael/Meirav Thanks! :)

Hey @Mila2999 ! We would like to merge this PR as-is :) we have fixes for mine and @talkor's comments in a different branch you really did brilliant job! would...

Hey @ramarm, thanks for reporting! I was not able to reproduce: https://stackblitz.com/edit/vibe-bug-report-45lec6 Can you create a reproducible example please in a clean environment?

> Hey @YossiSaadi , I created a simple example - [ramarm/vibe-bug](https://github.com/ramarm/vibe-bug) Clone the code and start it. You should see the problem this repo does not seem to include monday-ui-react-core...

Hey @wagoid, was wondering if there was any progress regarding that? I'm the one created #757 btw, so would love to know if my issue somehow helped

Hey @wagoid, I've forked created a PR #806 also tested it and it seem to work perfect :) The PR: https://github.com/yossi-test-org/test-merge-queue/pull/24 ![image](https://github.com/user-attachments/assets/084908da-c399-40c6-8c5e-a2c13c2c44b1) with bad squashed commit: https://github.com/yossi-test-org/test-merge-queue/actions/runs/12221132350/job/34089796604 ![image](https://github.com/user-attachments/assets/4d9a96cf-f6e9-4a34-90f1-3bed7da9027d) with good...

> As a general comment - I suggest providing a single codemod for vibe 2 =>3 migration instead of multiple ones. > It should be easier to run instead of...

@shaharzil @talkor I'm not a big favor of the name I gave to that component, but I think using just Wizard here is too confusing, as it is only responsible...