Yehouda Harpaz

THe tests assume the current directory

1

The tests assume that that the current directory is the system directory when they use relative pathname to access the dictionary. That is not correct assumption,. The best way to...

Define-modify-macro requires a symbol as the function argument, but in src/lib/macros.lisp it defines **reversed-deletef** with a lambda. That would give an error on any proper common-lisp implementation. http://www.lispworks.com/documentation/HyperSpec/Body/m_defi_2.htm

LispWorks specific: were slots change from tnon-transactional to transaction, the parents need (:optimize-slot-access nil)

1

The code already adds (:optimize-slot-access nil) to transactional classes, but when such a class is inherited from non-transactional class and overrides a slot to make it transactional, it needs to...

The function render uses parse-backtrace and relies on it to return a list where the third element is a list of frames. On LispWorks it fails, the third element is...

Running the tests gives an error in the test **download-box** inside the function **box-directory**, because the **version** slot the **box** (which is **+box+** , defined in t/setup.lisp) is unbound. It...

make-tarball in t/setup.lisp sets \*default-pathname-defaults\* to the directory of the tarball. At least on LispWorks Windows, that fails because because it also needs the host, which contains the device character....

update-indentation-information should not error when *emacs-connection*

4

Currently, doing: ``` (ql:quickload "SLYNK/INDENTATION") (ql:quickload "softdrink") ``` Gives an error (on Lispworks): ``` Error: NIL fell through ETYPECASE expression inside SLYNK::SEND-TO-INDENTATION-CACHE. Wanted one of (SLYNK::SINGLETHREADED-CONNECTION SLYNK::MULTITHREADED-CONNECTION). ``` because \*emacs-connection\*...

LispWorks specific: the process slot of an acceptor may be unbound

2

In the LispWorks version of start-listening, the acceptor process slot is is set after comm::start-up-server returns, which happens after the server starts to work, so something may try to access...

LispWorks specific: socket-accept should check is actually got a socket

1

**socket-accept** for **stream-server-usocket** in backend/lispworks.lisp needs to check that the socket it got from **comm::accept-connection-to-socket** or **comm::get-fd-from-socket** is not NIL, because both of these can return NIL for failures. What...

LispWorks specific: socket-shutdown on stream-usocket need to pass the stream to comm:socket-stream-shutdown (rather than the socket)

2

in backend/lispworks.lisp, the method socket-shutdown on stream-usocket currently calls comm:socket-stream-shutdown on the socket, which is wrrong, because comm:socket-stream-shutdown expects a socket-stream. It needs to pass the stream, that is replace...