Yashish Dua comments

Results 17 comments of


                                            Yashish Dua

Looking for new maintainer(s)

I would love to contribute!

NewClient mutates global Logger

Checking in if this needs more discussion or ready to get into the implementation state?

NewClient mutates global Logger

Perfect! Picking this up then.

Attached new logger instance to client

@rhcarvalho You can have a look now!

Attached new logger instance to client

@rhcarvalho Any update on this?

Improve how to set levels on events

@rhcarvalho Is this issue open to pick up? I have contributed in the early days of this repo.

Improve how to set levels on events

@rhcarvalho Alright! Would get back here soon.

Improve how to set levels on events

@rhcarvalho I was going through the code base and Unified API principles and thinking if we can have an optional `level` argument for the `CaptureException` method. What do you think?...

Improve how to set levels on events

@rhcarvalho > There are no "optional arguments" in Go. The closest to that are [_Variadic Functions_](https://golang.org/ref/spec#Function_types). > > If we make a change like this: > > ```diff > -func...

Improve how to set levels on events

```go type exceptionLevel struct { level Level } func createException(exception error, level *exceptionLevel) {} ``` Something of this sort, with better names.