Yaniv Davidi

Results 14 comments of Yaniv Davidi

> have u figure it out ? We don't have any update yet

Hi 👋 I'm working to create an OpenTelemetry ruby instrumentation for `aws-sdk`. It's going to be my first ruby instrumentation and I'm looking for guidance (I created Node Elasticsearch instrumentation...

@arielvalentin Thanks for your comment. Is there any automated process to test the instrumentation against all `aws-sdk-ruby` versions?

In JS aws-sdk instrumentation there's an option to [suppressInternalInstrumentation](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-aws-sdk#aws-sdk-instrumentation-options). When setting true, it hides all underlying http spans. Do you think it should be also an option in `aws-sdk-ruby` instrumentation?...

I believe this issue can be closed now, after https://github.com/open-telemetry/opentelemetry-ruby/pull/1014 merged

This is `fields` method. If I understand it correctly, it looks like it is calling itself recursively. ```rb # Returns the union of the propagation fields returned by the composed...

> Is that correct? What happens if it exceeds the 10 fields? Correct. When setting more than 10 message attributes,`sqs.send_message` method raise the following error: `Number of message attributes [12]...

> Those fields are also dynamically generated based on the contents of the Context field, so you likely will not see them as "fields" if someone is using that propagator...

This PR allow users to have process spans linked to the producer span. In this PR I followed the existing behavior in node instrumentation and the [current messaging spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/messaging.md): >...

I won't be able to make the requested changes in the near future. I would really appreciate if someone can assist and implement the changes for this PR.