Yamen Merhi

Results 21 issues of Yamen Merhi

## What does this PR introduce? - Adding function signature for ERC725Y functions - Add an example to use specific notations when calling ERC725Y overloaded functions - Mark standard as...

## What does this PR introduce? - Use `uint8` instead of `uint256` in LSP7 decimals We don't need `uint256` for decimals, `uint8` is more than enough. With `uint8`, decimals can...

## What this issue is about? As it presently is constructed, the contract is vulnerable to the allowance double-spend exploit, as with other ERC20/LSP7 tokens. Exploit Scenario: 1. Alice allows...

discussion

## What does this PR introduce? - Introducing **LSP11BasicSocialRecovery** standard specs

## What does this PR introduce? - Updating the example to be more comprehensive + more updated. - Simplifying the EIP191 Standard, by providing more explanation of the different versions....

c-update
t-erc
a-review
s-final

## What does this PR introduce? - Documenting the new logic inside the `universalReceiver(..)` function of the LSP0-ERC725Account and LSP9Vault

### 🧐 Motivation In the current `ECDSA` library, there is support to construct a message to sign according to the EIP191 Standard with the following: - The version `0x45` (E)...

Fixes #3912 - [x] Tests - [ ] Documentation - [x] Changelog entry

### 🧐 Motivation In the current `SignatureChecker` library, there is support to check if a signature is valid with the `isValidSignatureNow(..)` function that checks the following: - If the `hash`...

good first issue

### Suggestion While working with ethers v6, given chainId 42 it's returning Kovan. Kovan is now deprecated, and LUKSO Mainnet uses chainId 42. More info here: https://docs.lukso.tech/networks/mainnet/parameters Keeping it this...

documentation