Yashashvi Dave

Results 37 comments of Yashashvi Dave

@ryanle42 It's throwing error on password reset. Could you please investigate? It's returning error on reset callback, but it does send the reset email, which is confusing. There should be...

@aero31aero Please provide your review to this, since you have already reviewed #7725 it will be really helpful to me. It's rebased version of #7725 without any additional changes.

@timabbott It's updated! * Refactor the loading spinner code, to call default functions * Move templates style to css files * Set default style on discarding modal.

@timabbott I found the error, and suggest one way to solve it, which I am not sure it's best way to solve. Let me know your suggestions on this.

yeah, make sense. when subscribers are not included in list even the stream is checked, it creates confusion. PR also includes fixes of #9964 for issue #9480

@gnprice I have finally solve testing error. And sorry that I have pushed code without testing it locally, which resulted in so many commits.

@synicalsyntax I have squash them in one commit.

Format for form password error/warnings, zxcvbn-suggestions and zxcvbn-score is: ![passwordregister](https://user-images.githubusercontent.com/25907420/30779679-9fa0c844-a114-11e7-97b5-f5e658a70f88.gif)