Aleksei Khudiakov

Results 217 comments of Aleksei Khudiakov

I just realized that last example won't work - it will always cause failure on first pass.

I do not understand how it works entirely. My current understanding is that rendering happens twice - without data and on second pass with actual data. That means that first...

Same problem is exposed when trying to define custom type accepting object value ``` js convict.addFormat({ name: 'custom', validate: (val) => { console.error('validate called', val); }, coerce: (val) => {...

@boesing New features for the current major will be handled asap. My WIP was delayed at first and scrubbed by now, pretty much, with increasing scope of changes and everything...

@samsonasik it is handled as part of migration to coding standard v2. See #121

@samsonasik Do we allow or recommend arrow syntax? I don't remember TSC discussing it.

I'll review it a bit later. A lot of things become obsoleted or not recommended.

This emitter is dangerously brittle. Result would be drastically different if say some listener read from the stream and/or did a rewind. Or if `$request->getBody()` was used. Ideally this emitter...

A clarification needed: @settermjd by documentation structure I mean mostly writing structure?? of the documentation from the point of view of the technical writer. A structure for the detailed yet...

I am going to split introduction of type declarations into separate PR(s) to avoid unneeded work with other breaking changes.