Ryan McClelland
Ryan McClelland
the platform name could also be `cdimono1` due to the way mame works with driver look up :/
You need to run clang-format on `adc_ads1x1x.c` due to the compliance checks https://docs.zephyrproject.org/3.3.0/contribute/guidelines.html#clang-format
@efra-mx-aqua Please rebase and fix conflicts
Please rebase
> > Please rebase > > done for now. I don't see it rebased... it still has a merge conflict
> This looks incorrect: https://github.com/efra-mx/zephyr/blame/c2eed75ed0658c445f3bac66b9159a96a3b38269/drivers/adc/adc_ads1x1x.c#L481-L482 > > The COMP_MODE bit sets the comparator mode, it does not disable the comparator. The COMP_QUE bits disable the comparator. > > Also, you...
I did speak to @mbolivar-ampere over Discord, he said he doesn't see anything crazy but he'm not maintaining DT right now due to dayjob time constraints. I'll ping around on...
> > > This looks incorrect: https://github.com/efra-mx/zephyr/blame/c2eed75ed0658c445f3bac66b9159a96a3b38269/drivers/adc/adc_ads1x1x.c#L481-L482 > > > The COMP_MODE bit sets the comparator mode, it does not disable the comparator. The COMP_QUE bits disable the comparator. >...
I have this set to a draft because I want to run through some more test cases to make sure I didn't break anything else... I also have before/after change...
> First: > Thanks for documenting the variables. +1 Makes sense to me. However, I guess the wording needs some review (e.g. surplus "the"). My suggestion: Why not renaming `mScrollTier`...