Jacob Kiesel
Jacob Kiesel
Consider the following C++ code (taken from libwebm) ```cpp class BlockEntry { BlockEntry(const BlockEntry&); BlockEntry& operator=(const BlockEntry&); protected: BlockEntry(Cluster*, long index); public: virtual ~BlockEntry(); // ... enum Kind { kBlockEOS,...
> Maybe only `char` is needed? I guess `signed char` and `unsigned char` will always be the same as `i8` and `u8` on platforms that Rust supports. __Originally posted by...
Closures are allowed to reference data that may be dropped before the closure itself is dropped currently. This will result in undefined behavior. This can't be meaningfully prevented in C++,...
Due to technical limitations in the C preprocessor this only supports 16 arguments. I suspect 16 is plenty, but I'd someday like to remove this limit. In the short term,...
The current technique is very imprecise and likely to come up with false positives. We need a way to either filter out those false positives, or avoid generating them in...
https://github.com/serenity-rs/serenity/blob/current/src/model/channel/channel_id.rs#L538 This line will return `None` if the channel isn't in the cache. Thing is I'm pretty sure this is wrong. I expect this API to first check the cache,...
The `__dirname` value is important when trying to retrieve bundled assets. As far as I can tell there's no way to access this with `napi` currently, unless you write a...
Consider the following code ```rust #[napi] struct Foo { callback: Box napi::Result>, } #[napi] impl Foo { #[napi] pub fn set_callback(&mut self, callback: T) -> napi::Result where T: 'static +...
When the input string `LCD_info` is converted to PascalCase (aka UpperCamelCase) `convert_case` will emit `LcdInfo` whereas `heck` will emit `LCDInfo`. I believe `heck` matches the intent of the input string...
Imagine the following scenario: I have two crates that expose napi modules, I'd like to share some definitions between them and I'm not fond of duplicating code (Don't Repeat Yourself)....