WilliamRoyNelson

Results 11 comments of WilliamRoyNelson

> 👍 add test cases for every user facing field I wrote a little bit about this in my own issue, #1337 but I think it's something that deserves a...

@serena-ruan Are there additional steps that need to be done in order for this to be merged? It's been half a year.

I'm not very familiar with this project overall, so I don't know the right approach, but I feel like the documentation for the Python API, the license specifically, could be...

I guess it can't hurt to ask: Could you change the license for the PyPI package to Apache 2.0? But in any case, I definitely understand what I came here...

I've made a PR to fix this. As mentioned in the issue description, I'm a little unsure of how it works, but it's not exactly the sort of thing you...

This is also a convenient opportunity to add any additional [classifiers](https://pypi.org/classifiers/). @fchollet if there's any that you'd like me to add prior to merge, let me know!

To be clear, if there are compelling technical reasons to not make this change, don't feel like you need to break things. I'm mostly hoping that the only obstacle is...

I made this PR #570 but I'm not sure if the pyproject.toml file is generated programatically or not. Hopefully it's helpful!

Is the plan still to release what is in main around October 27th? I know CVE-2024-37891 (which will be fixed by the updated urllib3 package in main) doesn't seem like...

> Seems the license classifier was accidentally removed in [4e1e893](https://github.com/pypa/setuptools/commit/4e1e89392de5cb405e7844cdc8b20fc2755dbaba). Would it make sense to revert [jaraco/skeleton#170](https://github.com/jaraco/skeleton/pull/170) for the time being? I created a PR to temporarily re-add the license...