William Parker

The current hashcode implementations appear to follow the pattern [here](https://github.com/cerner/bunsen/blob/0.2.2/bunsen-core/src/main/java/com/cerner/bunsen/codes/UrlAndVersion.java#L39). For convenience I'll copy the method here: ``` @Override public int hashCode() { return 17 * url.hashCode() * version.hashCode(); }...

Throw exception when incomplete sessions definitions are given in def-rules-test

3

Def-rules-test currently silently ignores session definitions that don't come in tuples of 3. So for example: ```` (def-rules-test example-test {:rules [my-rule ...] :sessions [empty-session [my-rule]]} ```` This will compile but...

Duplicate result bindings in rules should cause an exception

1

The following rule compiles and a session with it executes: ```` (defrule sample-should-fail-rule [?binding LousyWeather))) ```` This repetition of result bindings between different conditions seems fundamentally nonsensical to me. I...

Previously when we've added functions to the [listener protocols](https://github.com/cerner/clara-rules/blob/0.20.0/src/main/clojure/clara/rules/listener.cljc) this results in breaking of consumers that implement them. This is annoying because many listeners only actually need meaningful implementations of...

Duplicate paths in :or condition not leading to multiple facts being inserted

1

This test fails: ``` (def-rules-test test-or-sharing-same-condition-in-same-production-duplicate-path {:rules [single-rule [[[:or [:and [:or [::a] [::b]] [::d] ] [:and [::a] [::d]]]] (insert! {:fact-type ::c})]] :queries [c-query [[] [[?c empty-session (insert {:fact-type ::a}) (insert...

Add node-sharing test namespace

1

We currently don't have much testing around node sharing in the rules network despite a significant amount of work done in the compiler to support it. This came up recently...

Create optimized Fressian handlers for tokens and elements

5

Currently Clara elements and tokens use a general Fressian handler for arbitrary Clojure records. This works, but is likely suboptimal for performance. This includes both things that impact records in...

Better options for Java 9 compatibility in project.clj

1

In https://github.com/cerner/clara-rules/pull/409 we added a profile with arguments necessary to run under Java 9. This profile will only be used during development by those running a Java 9 JVM. I...

@wdullaer reported a case that performs poorly (took over an hour to run before terminating the process) This case can be found at https://gist.github.com/wdullaer/cecf88b3266ba0ac90b4f060eefe5208 which, for convenience, I will copy...