Will Roper

Results 22 issues of Will Roper

This PR refactors `Filter.apply_filter`. In essence the method is unchanged but is now a bit more robust. - Documentation has been improved. - Can now integrate over `llam` or `flam`...

Filters

The `IR_Template` emission model handles the calculation of dust luminosity differently to the other models but doesn't need to. This should be brought in line with the other models where...

Dust

This PR introduces `EmissionModels` which simplify spectra generation by enabling the definition of tree-like templates for atomically defining complex models. - An `EmissionModel` encompasses a single step in spectra generation,...

Spectra/SED

Throughout the more complex `get_spectra_*` methods intrinsic and reprocessed are described in what appears to be a contradictory way, [e.g.](https://github.com/flaresimulations/synthesizer/blob/main/src/synthesizer/components/stellar.py#L763). This should probably read ``` reprocessed = transmitted + nebular...

Commenting
Spectra/SED

When `tau_v` is a list in `get_spectra_pacman` [this line](https://github.com/flaresimulations/synthesizer/blob/main/src/synthesizer/components/stellar.py#L970) is a duplicate of the above but says it should be escaped.

bug
Spectra/SED

The application of fesc [here](https://github.com/flaresimulations/synthesizer/blob/main/src/synthesizer/components/stellar.py#L305) is already handled within the C extension for a particle Stars object. We should move all applications of escape fraction inside the generate methods to...

particle
Spectra/SED

This Draft PR tracks the progress of type hinting the entire software package. This will take a while and require multiple merges along the way. Type hinting requires types are...

Code Style
Types

In an extension to #530 every dataset in a grid file should contain units which we can then read and attach to a `Grid`. As it stands we assume erg...

grid
Units

While typing `sed.py` I ran into an issue with mypy and `__rmul__` which I'm yet to resolve but it got me thinking. All the dunder multiplication functions do is scale...

Spectra/SED

`igm.py` hasn't been touched since its inclusion. It's devoid of any form of documentation, uses uninformative naming conventions and breaks style rules.

Code Style
Clean up