Adam Wierzbicki

Results 17 comments of Adam Wierzbicki

@HCastano I will resolve the comments.

@HCastano I've made some changes according to your comments. Here's the `substarte-contratcs-node` code with the extension installed: https://github.com/Wiezzel/substrate-contracts-node/pull/1 CI tests are failing, but it seems to me that is *not*...

@HCastano All checks passed! 😄

Back when the payments team existed we had the following idea of a "good enough" solution: 1. Assume that 99% of transactions would be done with a gasless driver (zkSync)...

@nieznanysprawiciel What is the status of this?

Well... it's 2021, I'm using pylint 2.9.3 with Python 3.8.0 and still getting this issue.

@guillaumemichel Implementing an external 'peer address cache' behaviour is a fine solution for me as well. But in order for it to work, the addresses discovered by kad lookup need...

@gabrik I have implemented this custom matching logic: ```rust fn version_matches(version: &semver::Version, req: &semver::VersionReq) -> bool { if req.matches(version) { return true; } // This custom matching logic is needed,...

May I suggest additionally supporting `X-Forwarded-Scheme` header? (It's mentioned in a comment, but only `X-Forwarded-Proto` is supported).

It also seems to me that the extraction from `parts` is not really working. I've added a debug print statement there and the `parts.uri` seems to contain **only URI path**.