Steven Jeuris comments

Results 123 comments of


                                            Steven Jeuris

Verify potential concurrency issue of repository calls within application services

Should all RPC and event handlers be idempotent by convention?

Verify potential concurrency issue of repository calls within application services

Potential issues: - `ParticipationServiceHost.getActiveParticipationInvitations` calls both `getParticipationInvitations` and `getParticipantGroupList` on `ParticipationRepository`. - `ProtocolServiceHost.updateParticipantDataConfiguration` calls both `getByOrThrow` and `getVersionHistoryFor` on `StudyProtocolRepository`. For both of these, the repo can't become inconsistent, but...

Add phone number input data type

I split off the [informed consent issue here](https://github.com/cph-cachet/carp.core-kotlin/issues/450).

Add phone number input data type

> Has been implemented in CAWS. Okay; that makes it less urgent to implement in CARP core, but I think it is still a valid CARP core type, though. 🤔...

Storing `triggerId` and `deviceRoleName` in `TriggeredTask` is redundant

I presume you mean that [the polymorphic type descriptor of individual data points duplicates the data stream data type on data uploads](https://github.com/cph-cachet/carp.core-kotlin/blob/develop/carp.data.core/src/commonTest/resources/test-requests/DataStreamService/1.1/DataStreamServiceTest/appendToDataStreams_succeeds.json#L42): ``` "batch": [ { "dataStream": { "studyDeploymentId": "3de35fb5-c39e-4fea-8ccc-3a70ca618ce7",...

Verify potential concurrency issue of repository calls within application services

At the time of writing, there are _no_ application service calls which contain two _update_ calls. With the fix of #398, out-of-date repo updates can now also be handled by...

Implement unit of work pattern for repositories

This may also be important to safeguard that a repository update and matching domain event which is published occur as one transaction. Currently, if a repository call succeeds, but an...

Add sensor specifications linked to measure data types

Example: a PPG specification could hold a list of `LightSource`s: ``` /** * Describes a light source used as part of collecting [PPG] data. */ @Serializable data class LightSource( /**...

Add sensor specifications linked to measure data types

> In terms of hardware sensors (incl. the ones on the phone), I think the most important part is to store device information like serial numbers, model names, OS versions,...

Which devices require registration and which one are 'dependent'?

The second part '**required registration**' is addressed in https://github.com/cph-cachet/carp.core-kotlin/pull/119. > All devices require registration on the back-end before a deployment can be considered 'ready' (https://github.com/cph-cachet/carp.core-kotlin/commit/eb4aa8862be1cb24c8272a6dce7c8004b96ee782). The previous `requiresRegistration` is now...