Steven Jeuris

Results 123 comments of Steven Jeuris

@NGrech It sounds like this doesn't belong to CARP core, but to CAWS, no?

@NGrech Can you link to documentation on what this is about? [As part of upgrading to Kotlin 2.1](https://github.com/cph-cachet/carp.core-kotlin/pull/501) I did not run into any such deprecation notice. Searching official documentation,...

I don't really consider that a hack. If you look at [the system decomposition](https://camo.githubusercontent.com/d8152d9d7e4bb045474ad30b89f9e11cef7842ea3e83c7913e61927c84b1d475/68747470733a2f2f692e696d6775722e636f6d2f68457354484e6b2e706e67), you see there is no dependency from the client to the _studies_ subsystem, but only to...

> This is needed to get resources for the "study" (and not just the personal deployment). That makes sense. That's indeed why a "resources" subsystem in core was expected, and...

I think you are right this means the following line of reasoning was invalid: > Either way, with the current recommended claim-based access documentation, the researcher who set up the...

Fixed in https://github.com/cph-cachet/carp.core-kotlin/pull/513

Regarding `@Required`, I [found something relevant here](https://github.com/cph-cachet/carp.core-kotlin/issues/169#issuecomment-915341765) in context [of a fix I applied](https://github.com/cph-cachet/carp.core-kotlin/commit/cfdccc60a77e2e723d97cd97c00e864f8da52cd5). > Missing `@Required` attributes on fields which should always be serialized but had values assigned by...

> One work around I can think of is creating a new datatype/class to handle ApplicationData instead of using String, then we can set and enforce serializer for that class....

That can easily be resolved with a version migration, so only a minor version bump is needed. But, definitely out of scope here. 👍

That sounds trivial/easy enough to include! It would have to live in the studies subsystem, since this type of personal information should be kept out of the deployments subsystem. The...