Wenxing Hou comments

Results 9 comments of


                                            Wenxing Hou

Add raw key support in spdm_device_secret_lib_sample

> Question: Have you tested only enable LIBSPDM_ECDSA_SUPPORT or only enable LIBSPDM_RSA_SSA_SUPPORT ? I have added some macros in switch code to pass only LIBSPDM_ECDSA_SUPPORT/LIBSPDM_RSA_SSA_SUPPORT.

consider big endian system architecture

I will check it.

Split get_version/get_capabilities/negotiate_algorithms request.

@PrithviAPai We talked about: you suspect that this issue may be related to the following logic, and I am checking it. ``` In libspdm_send_request we are taking backup of the...

Split get_version/get_capabilities/negotiate_algorithms request.

> > @jyao1 , here is my sample code which I used to test the PR. > > ``` > > bool getVCA() > > { > > std::array request;...

Split get_version/get_capabilities/negotiate_algorithms request.

@PrithviAPai Hi. In libspdm, we first build the request and then call the `libspdm_send_request`, which will fill the `context->last_spdm_request`. In your test case, you use your own send function. I...

Add send/receive to `spdm_common_lib`

Thanks for your commit. And I compare the change: no code changes, only positional changes. LGTM. Please submit commit too in spdm-emu if the PR is merged.

[SPDM 1.3] CSR: add param1 and param2

> I think we may need a truth table for the reset required use case. > > Overwrite CSRTrackingTag Pending CSR Reset Action > No 0 No - ResetRequired >...

[edk2 rebase - task 1] Cherry-pick required commits on top of recent edk2

Hi all, I am upstreaming the missing features for CryptoPkgMbedTls.

Add unit tests and fuzz tests for get_key_pair_info

I am reviewing the PR. Thanks.