Wagner72
Wagner72
+1 It would be nice to see a ready implementation of this feature request
@levkk, Why is CI crashing on std::sync::OnceLock? This feature was stabilized in Rust 1.70.
@levkk , I think I found the cause. The Dockerfile.ci file uses Rust 1.67, so the compilation fails. Is there any reason why CI uses Rust 1.67? I could rewrite...
> We use `once_cell` elsewhere in the code, so it's not a bad idea to use it here too. We can move to `OnceLock` at some point later, for every...
> We use `once_cell` elsewhere in the code, so it's not a bad idea to use it here too. We can move to `OnceLock` at some point later, for every...
> I have a couple thoughts, I'll review this PR today/tomorrow. It's the right direction through, so we're very close. Okay, sir I'm thinking of removing the re-initialization of root_store...
@levkk , Please review it now. I've also updated the PR header. A nice bonus: by using OS certificates, the binary file size is reduced by about 750KB. For some...
@levkk, I did everything you mentioned. Currently, loading root certificates on PGCat startup will not occur unless the `verify_server_certificate` setting is configured. Root certificates will only be loaded in the...
I think PR is ready. @levkk , review it please
> We need to figure out why this doesn't build in CI and then we can probably merge this as is. Without CI, we haven't tested this PR yet. >...