Wes Byrne
Wes Byrne
Someway to open links would be a big win. I'm actually using Nativefier with Clubhouse as well and since our team shares lots of links I'm constantly ending up back...
My opinion: The current name and location (`layer.layersByConvertingtoOutlines`) is more clear than having it on `Layer`. `Layer.fromOutlines(layer)` actually feels a little more awkward to me. If anything, maybe something like...
Any more thoughts on naming for this?
@mathieudutour Let me know if and how you want me to update this. Happy to do whatever you think makes the most sense.
No worries, just remembered this had been sitting here for a while. This is an easy one to drop in to the internals for now.
This PR needs to address this issue that was [brought up in Slack](https://sketch-friends.slack.com/archives/CCXDEQG9H/p1570219535048800) 👇 . @christianklotz any insight on how this can be achieved in code? I'd be happy to...
As for failing when `canConvertToOutlines` is false, do the internals return nil or itself? Should that check function be adde here as well?
got it. I feel like returning nil then, or maybe even throw an error to make it clear why it didn't work. If you are trying to convert something to...
If those are the only 2 that support it, that works for me. I was just kinda going with what the internals seemed to do. FWIW, I only use it...
I'm not totally sure how this function works on different kinds of layers but here is a basic Implementation: https://github.com/WCByrne/SketchAPI/tree/add-convert-to-outlines