Warren James comments

Results 12 comments of


                                            Warren James

feat(NODE-6044): add detailed types for `SearchIndexDescription`

Hi @noseworthy thanks so much for all your work on this PR. We're currently reviewing this and will get back to you soon.

feat(NODE-6044): add detailed types for `SearchIndexDescription`

Hi @noseworthy! Thanks for your patience and thanks again for all your hard work on this PR. After reviewing it with the team, we've decided that accepting these changes into...

fix(NODE-5723): emit TopologyDescriptionChangedEvent just before close

~Note: getting spec test failures, but they disappear when _only_ running the tests in question.~ Failures were coming from old modified spec tests that have now been removed.

fix(NODE-5723): emit TopologyDescriptionChangedEvent just before close

Note: this branch was rebased against #4089 which implements the UTR changes introduced in DRIVERS-2875

feat(CSOT) - feature branch

[Evergreen link](https://spruce.mongodb.com/version/663562e134c6bf0008c9c9e4/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC)

@aditi-khare-mongoDB @nbbeeken should we conditionally clear the timeout on success/a non-timeout failure based on whether or not we created the timeout inside the function that we race the timeout with?...

ci(NODE-5736): update aws auth host and ecs task

note that ECS tests are running into the following failures: - `-no-optional` tests fail due to permissions error ``` [2024/01/25 10:38:05.577] sh71672| + npm run check:aws [2024/01/25 10:38:05.577] sh71672| [2024/01/25...

feat(NODE-6289): allow valid srv hostnames with less than 3 parts

Failing tests are unrelated known flaky tests

fix(NODE-6407): use conversationId returned by the server instead of hardcoded integer in SASL implementation for MONGODB-AWS.

@kggau I've put up a PR with test for this change (#4368) and will be merging this PR into that new branch to have the change and the test in...

feat(NODE-6275): Add CSOT support to GridFS

Note, tests currently failing since mongodb-legacy does not currently pass through the options for some methods that now have an options argument, being addressed [here](https://github.com/mongodb-js/nodejs-mongodb-legacy/pull/48)