Vincent Latombe
Vincent Latombe
Could I get a review from @jenkinsci/core-security-review ? This has been hanging for a while now.
> Is there a plugin in jenkinsci you could demonstrate use of this new API with? Sorry I have other high priority tasks (and the initial use case that drove...
I don't think it can work this way. In any case, it should be already doable using the `yaml` field.
Coming back on this PR, I fail to understand what is the use case. The current pod template model in the plugin defines volumes which get mounted in all containers....
Looking at this.
The test failure definitely looks related to the change ``` 8.422 [id=1257] INFO o.c.j.p.k.KubernetesNodeDeletedTask#run: Pod octal-permissions-1-gvp1l-6c5nx-bbf28 has been confirmed deleted. 8.423 [id=1257] WARNING o.c.j.p.k.KubernetesProvisioningLimits#unregister: Pod template count for octal_Permissions_1-gvp1l-6c5nx went...
> In our testing, it was seen that this operation could take upwards of 100 seconds when under load, causing provisioning to be effectively stopped for periods of time. This...
This step is completely local and I don't think there is justification for running it asynchronously. However, the current pod template inheritance certainly can be expensive to compute (due to...
Would you mind trying out #1178 ? This should already speed up the main loop and I still don't think asynchrony is necessary here even if the framework allows it.
Right, this probably due to the required queue lock...