Yingrong Zhao
Yingrong Zhao
Here's the link to the CI pipeline when this happened last time: https://dev.azure.com/getporter/porter/_build/results?buildId=4401&view=logs&j=c892508d-390a-5765-0ad0-b341c7fd0dd4&t=99b6391b-efca-5f28-e88f-b44afecfc894
``` === Step Template === exec: command: ./helpers.sh description: Install Hello World umens: - install === Rendered Step === exec: command: ./helpers.sh description: Install Hello World umens: - install Install...
After chatting with @carolynvs , we have decided that for v1.0 we will not introduce this new behavior since it may results in porter build failing for bundles that work...
Hey @sgettys , I just created a simple bundle just to make sure that I understand the scenario. Is this what you are trying to do? If not, do you...
I agree that the default behavior should return an error instead of overwrite the existing bundle
Hi there, thank you for reporting the bug. It looks like we are using type`string` in our protobuf definition https://github.com/getporter/porter/blob/db2fed13ec4e0da8d03068ddef08e7c0760a1b16/pkg/secrets/plugins/proto/secrets_protocol.proto#L18 It may need to be updated to []byte instead to...
I found a library that implements a filter extension for zap.Logger that we could use for implementing this feature https://pkg.go.dev/moul.io/zapfilter#section-documentation
Thanks for submitting the PR, @joshuabezaleel ! Just an FYI, Carolyn is going on vacation so I will be reviewing the PR in the meantime
https://github.com/getporter/porter/issues/1980
Hey @sgettys , thanks for working out the fix for this! Feel free to remove the WIP in the PR title whenever this PR is ready for review. Just through...