Vinícius Garcia
Vinícius Garcia
Uhm, I was just thinking about what I just wrote, I think there is another alternative you might find cleaner, especially if the user wants to receive different types of...
That's a true problem I have to figure out a good solution. Currently, there is a hard-coded solution that solved this for "(", ")", "_" and string delimiting characters, but...
Update: JavaScript uses mark & sweep, and Python uses Reference Counting + Mark & Sweep specialized for data cycles. So we will need to implement a mark & sweep garbage...
@sillydan1 I noticed you added some commits, I'll take a look soon, but I am really busy with some stuff, so soon might mean one week, or a little more....
Hello @sillydan1, I've got some time recently so I finally made the change I said I would. It is working for the common cases, but regarding the tests you got...
Yeah I know, it is hard to get time to work on these projects 😅 So I will try to update those tests in the end of the week =]...
I had this same problem and the PR https://github.com/actions-runner-controller/actions-runner-controller/pull/1354 is the fix I implemented for it. I am hoping we can merge it soon, but @kmlevy if you want you...
Hey, @mumoshu thanks for reviewing it. This configuration is actually not working as expected because there is no `githubWebhookServer.ports` config in the `values.yaml` file of the Helm Chart. We are...
@kmlevy the PR I created was now merged maybe it fixes the issue you experienced here: https://github.com/actions-runner-controller/actions-runner-controller/pull/1354 If it does we might proceed to close this ticket maybe
Hey @sillydan1 I am sorry I never got back to it, but if we just fix those tests we can merge this one.