Ryan Haksi comments

Results 5 comments of


                                            Ryan Haksi

Simple test case is producing allocations, is this intended?

DOH: Just noticed, a merge just went in that fixes `var stackbuf [unescapeStackBufSize]byte`, I have updated and the new code doesnt have this allocation happening.

Simple test case is producing allocations, is this intended?

> Interesting 🤔 > > This change was part of the code to actually reduce allocations #208 Huh, no idea why that fixed things, but you're right, your last released...

Simple test case is producing allocations, is this intended?

#223 PS: Ugh, I missed pIdxFlags, which when changed similarly via : ``` pIdxFlags := make([]bool, stackArraySize)[:] if len(paths) > cap(pIdxFlags) { pIdxFlags = make([]bool, len(paths))[:] } pIdxFlags = pIdxFlags[0:len(paths)]...

Simple test case is producing allocations, is this intended?

On a semi-related note, for ease of use I wrap the EachKeys function with a helper to do field bindings and costlessly marshal directly to a struct: One side affect...

Struct unmarshmaling and more

> Doh, you're right, I guess I meant `refs :=` and then `refs[0]`, etc. Edited. > Doh, you're right, I guess I meant `refs :=` and then `refs[0]`, etc. Edited....