Miguel Victoria Villaquiran

Results 18 comments of Miguel Victoria Villaquiran

Hello @marten-seemann does this issue still needs someone to work on it ? I already start looking to the implementation document and this seems like something I'll like to do...

Just a little remark on this PR, With @omarsy we realized that even with this PR we could have some linter errors that are now shown. This happens when having...

> This will not work in a real life scenario, as `CurrentRealm()` skips frames of pure packages. (If you want a good side-task, change `NewCodeRealm` to work only with PkgPath's...

> Apologies, revert the changes in tests/files/extern and remove that dir from the fmt rule. > > `gno fmt` doesn't understand the imports in that dir and it shouldn't, so...

> CI failed. could you please check and fix this? I think it is ok just one does not want to finish do not know why @notJoon

Hey @jefft0 thanks for your review. I mean I could put g1sh0uldn0thappen but that being a non valid address, maybe it is better to fail if the parameter is not...