Victor Zeinstra comments

Results 29 comments of


                                            Victor Zeinstra

[question] Updating repo with rewritten module

Hi @chrillewoodz , first of all, thanks for your involvement in the project. I know there are lots of refactor needed to add to the project so any help is...

Swap host in decorator for HostBinding (TinderCardDirective)

Indeed, it could be better.

Undo deletion of element

@ITServicesAM I think that in order to get an undo functionality you could simply store in a variable a copy of the item representing the card beeing swipped. So if...

Add ChangeDetectionStrategy.OnPush for performance boost

I'm not a huge fan of data immutability because it breaks JavaScript references. So i guess that with this change, for example: if i want to change the overlay like's...

Move styles to separate file for better readability

I agree, but i think there is some webpack config to do in order to change this.

element.remove() should be swapped for a splice of the original array that is being looped

Well this would make huge change in the way the component works since until now it only treat the display and not the data itself. Currently it is possible to...

Bower support

Hi there, Thanks for your interest to the project. I will see if i can easily add the package to the bower repository. I keep you updated. Have a nice...

[urgent] Cards under the first one are swipeable

There is already a way to prevent this by setting the cards input fixed at "true" on all cards and "false" on the first one. however if it was automatically...

Rename files to <name>.<type>.ts to follow best practice

Yes indeed, it would be better

destroy function uses delay parameter but the setTimeout delay is hardcoded

Indeed. It's not normal