Björn Kautler

Results 936 comments of Björn Kautler

Just found that part of what I fix here was years ago reported already, but was attributed to dialect differences, which is not correct. So this PR fixes https://youtrack.jetbrains.com/issue/KT-49065

https://github.com/junit-team/junit-framework/issues/1880 was finally released 2 month ago with 6.0.0, so this could maybe be done properly now.

Do you have evidence it actually **is** the default? You say it is the default since 4 major releases. The current major release is v5. But what you linked to...

Well, having a look at their docs I'd say even if it were enabled by default, it is not the strictness we talk about here. As far as I understood...

@leonard84 what do you think?

Unfortunately the term "strict" is used very differently. EasyMock for example also has a strict mode, that there means that also invocation order is checked.

I don't think anything should be changed here. At most maybe adding some more clarifying documentation. There is no way to know whether a data provider is expensive or not....

> How can this be better for the user instead of just don't estimate the size? Again, you never know whether a `size()` method is unsafe or not. An implementation...

That's not so much a bug, more a performance optimization, besides that there is literally no way to get the behavior you expect. For example consider this even simpler example:...

You can just "toString" all exceptions, no need to type-check and access internals. Besides that, whether it will go into Spock @leonard84 has to decide, but I doubt it should....