Björn Kautler

Results 936 comments of Björn Kautler

I'm **not** talking about the file where the versions are stored. I'm talking about the `version.txt` file that is included in the plugin jar that contains the plugin's version.

"Still" like since I requested this 3 weeks ago? :-D Yes, it is still like that. I have no idea why, I just contributed SignServer support and had to do...

> [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite....

This of course also means that the `checkLicense` task is operating on different information than is shown in the HTML reports and might accept a library like the shown for...

That does not really fix the issue, as this issue is about missing the information in the report. Multiple licenses handling is sub-optimal yes, but also your PR only partly...

Here a consumer-side work-around that "fixes" the inventory HTML report in Kotlin: ```kotlin class EnhancedInventoryHtmlReportRenderer : InventoryHtmlReportRenderer() { override fun buildLicenseInventory(data: ProjectData): Map { val inventory = super.buildLicenseInventory(data) inventory .values...

I'm not sure whether we really should allow that. If it is a "given", then you should be able to specify it in the upper-most `given` block. If it cannot...

Or the other alternative: ```groovy given: "values for all tests below" def a = ... // Something relevant for test 1 when: "test 1" def test1Res = subject.doStuff(a) then: .......

> Note that we have an ordering option available on ResolutionStrategy, but I don't think that is the answer here. Interesting, didn't know that, thanks. But from what I see...

Without this PR `matches` on JS does not consider whether the full input would match the pattern if a shorter match is the first result and `matchEntire` tries to be...