Usman Akinyemi
Usman Akinyemi
> Add test coverage in test/units/testsuite-74.bootctl.sh I am not sure if I get the test coverage right.
> > > Add test coverage in test/units/testsuite-74.bootctl.sh > > > > > > I am not sure if I get the test coverage right. > > It does not...
Thanks for the review @bluca, I will make the necessary changes.
> I started with a review, but before I continue: please output properly normalized JSON data, i.e. always use the most appropriate types. Formatting integers as json string is _not_...
> I started with a review, but before I continue: please output properly normalized JSON data, i.e. always use the most appropriate types. Formatting integers as json string is _not_...
@bluca I made the necessary changes. Kindly help review. Thank you.
@bluca, I am bringing your attention to this. Thank you very much.
@bluca, thanks for the review, I went through my implementation again and I made necessary changes to ensure the json contains data and not string.
@bluca , I am bringing your attention to this. Thank you very much.
@bluca Thanks for the review, I really appreciate your time. I made the necessary changes. Kindly help check. Thank you.