Dr. Ulrich Thomas Gabor
Dr. Ulrich Thomas Gabor
I added one test-case. There should be a functional one too I guess (something simulating a Command/Controller/Service creating a `DummyEntity` and inserting a `ReplacingFile`), I am not sure how to...
Ah my docker installation was broken. Fixed it, but still no luck: ``` make tests make vichuploader-image docker build -t dustin10/vichuploader_php74 -f ./docker/Dockerfile74 . [+] Building 474.6s (11/11) FINISHED =>...
Yes, this works. I've taken a look again at the test, but I do not really see how to perform useful tests in the current test setup. The test I...
The static analysis must have failed before. I did not structurally changed the if clauses and my editor complains about the same code position on `master` too. I corrected them...
My editor reports a problem on line 36 of `AbstractStorage.php` on `master` already.
The return type of the method differs from the return type given in the PhpDoc, that was the case before my changes already too: https://github.com/dustin10/VichUploaderBundle/blob/23ee93cd3b84afaa20ce69ba8399a9098bdb07f6/src/Mapping/PropertyMapping.php#L75-L79 Fixed it anyway.
phpstan is happy now, rest is here: > I've taken a look again at the test, but I do not really see how to perform useful tests in the current...
I fixed the second test. Please take a look.
You want 8.1 `readonly` and change the pipeline or should I remove it?
Is this still needing something from me here?