Gordon Bleux

Results 15 comments of Gordon Bleux

the changes are backwards compatible. the default values for the 3 new parameters are either the same as the previously internally configured ones ($package_name), or *false*, which causes most of...

yes, i will provide a PR

is there anything else that needs to be done for this PR to be merged? the failing `CI / Puppet / 7 - Archlinux rolling (pull_request)` check seems to be...

i was still using ruby 2.5; puppet-strings 3.x requires ruby2.7+, which is why my local dev env never got a newer gem version. i have rebuilt the reference using ruby-2.7/puppet-strings-3.0.1

i can come up with a PR to get this feature implemented

> For standard pages (index, baskets, basket) I do not need the power of Sprig, I guess. i know. i just applied it to all templating use for consistency reasons...

i am not entirely sure why the E2E tests fail. i tested it against the mock provider without any problems. the k8s mock seems to be missing from the source...

> Thanks for the PR. > > When I read the code correctly, you want another resolver, that reads all (I guess Pods or secrets) resources that the currently used...

> > i am not entirely sure why the E2E tests fail. i tested it against the mock provider without any problems. > > the k8s mock seems to be...

this is a draft. i wanted to get some early feedback to see if this changes is acceptable. i still need to refactor the test suite. this change will replace...