Tyler Rick
Tyler Rick
I just got bit by this bug too. My use case was pretty simple, I thought: - A boolean column :accepted_terms and a view like this: - form_for @user do...
This looks good. Just need to figure out why CI is failing for 2.6: https://github.com/michaelbanfield/devise-pwned_password/pull/26/checks?check_run_id=513421333
Also, may want to call them "callback methods" rather than "template methods"...
I pushed the exact some code up as #34 and it passed CI, which seems to confirm that it's just an intermittent failure. Looks like that also caused the status...
It would be nice if we could simply call it `Devise::PwnedPassword.enabled`, but using top-level Devise config, `Devise.pwned_password_check_enabled`, seemed to be the most consistent with what this gem is already doing.
My preference would be to make this gem more like a wrapper for [pwned](https://github.com/philnash/pwned)'s `not_pwned` validator (I may explore that idea in another PR), but where that's not possible, it...
Not a bad idea! Too bad it would render use of https://github.com/philnash/pwned library redundant. I feel like pwned is a more solid library, and certainly seems more configurable, so I'd...
> @TylerRick This is failing CI because CI is testing against Rails < 6. I think the appropriate next steps are: > > 1. Open a separate PR to add...
Okay, finally got tests passing. Merge please? Wasted too much time getting it to work with old Rubies/Rails, when I think the correct path should be to just remove support...
I ran into a similar problem (mine happened to be due to Sprockets 4, but I'm sure I would/will eventually run into it with Webpack too): see #110 I thought...