Trevor Sundberg

Results 17 comments of Trevor Sundberg

I'll be honest, I don't use git; I use hg/mercurial so I'm not familiar with git pull requests... but I'll try!

This is my first real GitHub PR (I'm used to Azure Devops), when I commit and push the comments that were made just show `Outdated` and the old code. In...

I'm very curious as to what vmill is, does it run a program by JITing the llvm?

That could certainly be done. The main offender is: https://github.com/TrevorSundberg/h264-mp4-encoder/blob/542fc995327e6549bc3019ad8cd5d9c5bf8d585c/CMakeLists.txt#L131 If you remove that line it will build as a wasm file. We could maybe read that as an environment...

It's certainly possible on the back end, the only issue is UI. On my road-map I wanted to redo the sticker search UI as I'm currently using a third party...

I would possibly try listening to the `targetcreated` event. Let me know if this works, as I might add a documented workaround for this case (or simulate the `popup` event).

@mikeda37 What version of puppeteer-core/electron?

Hi luqihao, I actually tried this already however it breaks the tests. Please feel free to try as it looks like you’re doing, but also run the tests. I think...

Sorry about that, not sure how I missed this bug report, it was a great find! I don't know why, but using `node-fetch` was causing the delay. We were making...