Trevin Avery comments

Results 13 comments of


                                            Trevin Avery

Image srcSets not escaped, breaks on paths with spaces in them

I just discovered this is still an issue. For clarity, the correct output should be ```html ```

User-Agent version is incorrect

If you want to use `webpack`, you could solve this issue with the `DefinePlugin`. dohjs/webpack.config.js ```javascript const webpack = require('webpack') const package = require('./package.json') module.exports = { plugins: [ new...

Tab crashes if stream is left open after scanning a QR code

Just tried v2.3.17. Still crashes. I did it twice, and it crashed both times. In each case, I brought up the stream and just scanned random qrcodes on google images....

Tab crashes if stream is left open after scanning a QR code

Ok, I have created a simple repo that should make it possible to reproduce the issue with one slight variation: It does not crash the tab. Instead, the worker throws...

Add support for AbortController signal passed via context

Duplicate of #302

Pass fetchOptions to fetch call to match HttpLink behavior

@fbartho I have signed the CLA. #296 does appear to add support for the abort controller, however, this PR supports all fetch options as overrides. I would take this one...

Pass fetchOptions to fetch call to match HttpLink behavior

I can't say for sure how likely it is that another link will pass in a body and cause an issue. But I imagine if that happens, then it is...

Pass fetchOptions to fetch call to match HttpLink behavior

@fbartho Sorry this took so long. I have had some serious deadlines at work. I have made the changes we discussed.

Pass fetchOptions to fetch call to match HttpLink behavior

@fbartho Can you please review this PR and let me know if it is acceptable?

Pass fetchOptions to fetch call to match HttpLink behavior

@fbartho Are you still out there? Can we merge this in please?