TonytheMacaroni

On a related note, `EntityRemoveEvent` isn't always called on chunk unload, as the chunk system rewrite does not end up calling `Entity#setRemoved` in some circumstances, just `EntityCallbacks#onTrackingEnd`.

> This is probably gonna be caused by upstream's DamageSource API and the logic changes surrounding that. Yes, the exact cause and fix is mentioned in the "Other" section. This...

Damage types with the `is_explosion` tag are handled differently in CraftEventFactory, where the code only uses the causing entity. The rest of the code uses the direct entity if one...

> the direct entity is used in projectile and that was the behaviour previous the DamageSource PR Not exactly sure what you mean by that? Damage from firework rockets trigger...

Did some testing, and encountered this error when tab-completing with an empty console: ``` [org.jline] Error while parsing line java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 1 at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:100)...

Would it make sense to make the flags present in the event mutable? That way plugins can directly modify the behavior of teleporting passengers/vehicles by adding/removing the flags.

Updated the PR to include the causes upstream added. Also moved the primary event call to `CraftEventFactory#callEntityRemoveEvent`, as using `ServerLevel.EntityCallbacks#onTrackingEnd` didn't provide the additional cause context, and that method isn't...

This does indeed fix the problem with fireworks. The issue with the causing entity for some other explosions (i.e. TNT) being wrong is still a thing, though. As far as...

That would fix the issue with TNT, but still, the call to `customCausingEntity` isn't needed in `Explosion`? That's the only area that that method causes this specific issue. And the...

Just to note, I don't have an account to view the upstream comments you're referring to.